28200[BUGFIX] Flash messages are not shown with AJAX requests
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Frans Saris +1
-
Verified V +2
- Markus Klein +2
- Frans Saris +1
Files 5
- typo3/sysext/backend/Classes/Form/Element/InlineElement.php2+1 −0
- typo3/sysext/backend/Classes/Template/DocumentTemplate.php+12 −0
- typo3/sysext/backend/Resources/Public/JavaScript/DragUploader.js+24 −0
- typo3/sysext/core/Configuration/DefaultConfiguration.php+4 −0
- typo3/sysext/filelist/Classes/Controller/FileListController.php+1 −0
Review log 15
-
Markus Klein commented on patch set 1 03/09/14, 17:15
Don't we support d&d in for indocuploads as well? If so, we should add this there too.InlineElement.php:942FlashUrl sounds a bit too much after Adobe Flash. don't like that association ;-) -
Mr. Jenkins commented on patch set 1 03/09/14, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14734/ : SUCCESS -
Frans Saris commented on patch set 1 CR +1 03/09/14, 20:07
@Markus InlineElement.php = indocuploads -
Frans Saris commented on patch set 1 V +1 03/10/14, 08:19
InlineElement.php:942ReplyMaybe use ajaxFlashMessagesUrl? -
Xavier Perseguers uploaded patch set 2 03/10/14, 10:37
-
Mr. Jenkins commented on patch set 2 03/10/14, 10:51
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14761/ : SUCCESS -
Markus Klein commented on patch set 2 CR +1 03/10/14, 11:28
thx for clarification. -
Frans Saris voted on patch set 2 V +1 CR +1 03/10/14, 14:47
-
Frans Saris uploaded patch set 3 03/10/14, 15:01
-
Markus Klein voted on patch set 3 CR +1 03/10/14, 15:13
-
Mr. Jenkins commented on patch set 3 03/10/14, 15:22
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14790/ : SUCCESS -
Frans Saris voted on patch set 3 V +1 CR +1 03/11/14, 09:45
-
Markus Klein voted on patch set 3 V +1 CR +2 03/11/14, 09:48
-
Markus Klein voted on patch set 3 V +2 03/11/14, 09:48
-
Markus Klein merged patch set 4 03/11/14, 09:48