Review main Merged

28200[BUGFIX] Flash messages are not shown with AJAX requests

Xavier Perseguers CR +2 V +2 Easy +42 −0 updated 03/11/14, 09:48

Commit message

Due to the use of DragUploader to upload files, flash messages
are not shown immediately but after manually reloading the page.

Review

  • Code review CR +2
    • Markus Klein +2
    • Frans Saris +1
  • Verified V +2
    • Markus Klein +2
    • Frans Saris +1

Files 5

Review log 15

  1. Markus Klein commented on patch set 1 03/09/14, 17:15

    Don't we support d&d in for indocuploads as well? If so, we should add this there too.

    InlineElement.php:942

    FlashUrl sounds a bit too much after Adobe Flash. don't like that association ;-)
  2. Mr. Jenkins commented on patch set 1 03/09/14, 17:19

  3. Frans Saris commented on patch set 1 CR +1 03/09/14, 20:07

    @Markus InlineElement.php = indocuploads
  4. Frans Saris commented on patch set 1 V +1 03/10/14, 08:19

    InlineElement.php:942 Reply

    Maybe use ajaxFlashMessagesUrl?
  5. Xavier Perseguers uploaded patch set 2 03/10/14, 10:37

  6. Mr. Jenkins commented on patch set 2 03/10/14, 10:51

  7. Markus Klein commented on patch set 2 CR +1 03/10/14, 11:28

    thx for clarification.
  8. Frans Saris voted on patch set 2 V +1 CR +1 03/10/14, 14:47

  9. Frans Saris uploaded patch set 3 03/10/14, 15:01

  10. Markus Klein voted on patch set 3 CR +1 03/10/14, 15:13

  11. Mr. Jenkins commented on patch set 3 03/10/14, 15:22

  12. Frans Saris voted on patch set 3 V +1 CR +1 03/11/14, 09:45

  13. Markus Klein voted on patch set 3 V +1 CR +2 03/11/14, 09:48

  14. Markus Klein voted on patch set 3 V +2 03/11/14, 09:48

  15. Markus Klein merged patch set 4 03/11/14, 09:48