Review main Merged

28269[CLEANUP] main_rte function of the ElementBrowser

Tymoteusz Motylewski CR +2 V +2 Expert +845 −734 updated 06/29/14, 10:40

Commit message

It splits 450 lines function into smaller pieces
and removes some duplicated code in the process.
It also opens a way to further duplicate removal
e.g. the code for selecting current folder.
This patch is not changing functionality,
just moving code around.

* splits main_rte into smaller chunks
* make main_rte method signature be consistent
  between class implementations and usage
* removes ~100 lines of duplicated code
  getPageSelectorHtml and getFileSelectorHtml
  are now inherited in the BrowseLinks
* removed few "@todo Define visibility" for methods
  which are called from outside

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 4