Review main Merged

28373[TASK] Remove checkbox "Include Access List" in be_groups

Georg Ringer CR +2 V +2 Easy +10 −30 updated 03/15/14, 21:17

Commit message

The checkbox "Include Access Lists" in the be_groups just produces extra
clicks and extra reloads. If you don't need those information in the
current group, just don't look at the tab.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Anja Leichsenring +1
  • Verified V +2
    • Wouter Wolters +2
    • Anja Leichsenring +1

Issues 1

Files 3

Review log 6

  1. Wouter Wolters voted on patch set 1 CR +1 03/14/14, 07:36

  2. Anja Leichsenring voted on patch set 1 V +1 CR +1 03/14/14, 07:37

  3. Wouter Wolters voted on patch set 1 V +2 CR +2 03/14/14, 07:41

  4. Wouter Wolters merged patch set 2 03/14/14, 07:41

  5. Mr. Jenkins commented on patch set 1 03/14/14, 07:45

  6. Ernesto Baschny commented on patch set 2 03/15/14, 21:17

    Although I also thought this was included in a rather speedy procedure shortly before release, I can understand the reasoning and I will let it in - even thou I considered reverting it for 6.2 to allow proper discussion about it also with the UX team. At the end I came to the conclusion that this should have been done years back when the ACL lists got this dedicated own TAB. This checkbox has made no real sense since then. So it's fine to get rid of it for 6.2 LTS.