Review main Merged

28399[BUGFIX] Fix Content-Disposition header sent by dumpFileContents

Frans Saris CR +2 V +2 Easy +4 −5 updated 03/14/14, 22:17

Commit message

This patch changes the Content-Disposition header so it is also
send when $asDownload isn't set with value inline and the filename
is between quotes.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Philipp Gampe +1
  • Verified V +2
    • Stefan Neufeind +2
    • Philipp Gampe +1

Issues 1

Files 1

Review log 7

  1. Mr. Jenkins commented on patch set 1 03/14/14, 20:07

  2. Philipp Gampe uploaded patch set 2 03/14/14, 21:33

  3. Philipp Gampe commented on patch set 1 03/14/14, 21:34

    ResourceStorage.php:1446

    needs update
  4. Philipp Gampe voted on patch set 2 V +1 CR +1 03/14/14, 21:34

  5. Mr. Jenkins commented on patch set 2 03/14/14, 21:48

  6. Stefan Neufeind commented on patch set 2 V +2 CR +2 03/14/14, 22:17

    To test for example mark a filestorage as not "is publically available". Then a request for a file in filelist will go group dumpFile and use the functionality here.
  7. Stefan Neufeind merged patch set 3 03/14/14, 22:17