Review TYPO3_6-1 Merged

28539[BUGFIX] Several typos in Page Browsing ViewHelper

Markus Klein CR +2 V +2 Normal +33 −24 updated 03/19/14, 17:33

Commit message

Fixing several typos and slips of the pen in the
PageBrowsing ViewHelper.

Without fixing all of them the page browsing ViewHelper
is not functional properly, that´s why i want to submit
them at once and also supply the fix for it.

That are these errors:
* Undefined but used class property prefixId
* Overwriting instead of appending content to already defined variable
* Not using UpperCamelCase for extensionName in Localization Utilty
* Accidentally using wrong variables
* Defining variable in for-loop which could be defined outside also
* Using undefined variable freeIndexUid

Review

  • Code review CR +2
    • Markus Klein +2
  • Verified V +2
    • Markus Klein +2

Issues 1

Files 1

Review log 2

  1. Markus Klein commented on patch set 1 V +2 CR +2 03/19/14, 17:33

    Straight backport
  2. Markus Klein merged patch set 2 03/19/14, 17:33