28558[BUGFIX] Invalid file used to compute image ratio in text with picture
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Marc Bastian Heinrichs +1
-
Verified V +2
- Markus Klein +2
- Marc Bastian Heinrichs +1
Files 1
Review log 12
-
Frans Saris voted on patch set 1 CR +1 03/20/14, 12:08
-
Mr. Jenkins commented on patch set 1 03/20/14, 12:09
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15354/ : SUCCESS -
Marc Bastian Heinrichs commented on patch set 1 03/20/14, 12:14
CssStyledContentController.php:591move this to the else, if $file could also be a fileReferenceCssStyledContentController.php:594since this is fileReference, better adapt the naming or call ->getOriginalFile() on the fileReference to get the File object -
Xavier Perseguers commented on patch set 1 03/20/14, 12:32
CssStyledContentController.php:594ReplyDone -
Xavier Perseguers uploaded patch set 2 03/20/14, 12:32
-
Mr. Jenkins commented on patch set 2 03/20/14, 13:02
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15362/ : SUCCESS -
Marc Bastian Heinrichs voted on patch set 2 CR +1 03/20/14, 13:51
-
Marc Bastian Heinrichs voted on patch set 2 V +1 03/20/14, 15:46
-
Markus Klein voted on patch set 2 V +1 CR +1 03/20/14, 18:17
-
Markus Klein voted on patch set 2 V +2 CR +2 03/20/14, 18:18
-
Markus Klein merged patch set 3 03/20/14, 18:18
-
Vincent Mans commented on patch set 3 03/21/14, 08:59
It works now. Thanks.