Review main Merged

28558[BUGFIX] Invalid file used to compute image ratio in text with picture

Xavier Perseguers CR +2 V +2 Easy +6 −1 updated 03/21/14, 08:59

Commit message

Review

  • Code review CR +2
    • Markus Klein +2
    • Marc Bastian Heinrichs +1
  • Verified V +2
    • Markus Klein +2
    • Marc Bastian Heinrichs +1

Files 1

Review log 12

  1. Frans Saris voted on patch set 1 CR +1 03/20/14, 12:08

  2. Mr. Jenkins commented on patch set 1 03/20/14, 12:09

  3. Marc Bastian Heinrichs commented on patch set 1 03/20/14, 12:14

    CssStyledContentController.php:591

    move this to the else, if $file could also be a fileReference

    CssStyledContentController.php:594

    since this is fileReference, better adapt the naming or call ->getOriginalFile() on the fileReference to get the File object
  4. Xavier Perseguers commented on patch set 1 03/20/14, 12:32

    CssStyledContentController.php:594 Reply

    Done
  5. Xavier Perseguers uploaded patch set 2 03/20/14, 12:32

  6. Mr. Jenkins commented on patch set 2 03/20/14, 13:02

  7. Marc Bastian Heinrichs voted on patch set 2 CR +1 03/20/14, 13:51

  8. Marc Bastian Heinrichs voted on patch set 2 V +1 03/20/14, 15:46

  9. Markus Klein voted on patch set 2 V +1 CR +1 03/20/14, 18:17

  10. Markus Klein voted on patch set 2 V +2 CR +2 03/20/14, 18:18

  11. Markus Klein merged patch set 3 03/20/14, 18:18

  12. Vincent Mans commented on patch set 3 03/21/14, 08:59

    It works now. Thanks.