Review main Merged

2862[BUGFIX] Missing parentheses in code break two stdWraps

Markus Klein CR +2 V +2 Easy +4 −4 updated 06/03/13, 20:49

Commit message

Missing parentheses around isset() checks in string concatenation break
functionality.

Review

  • Code review CR +2
    • Tolleiv Nietsch +2
    • Steffen Gebert +2
    • Stefan Neufeind +1
    • Chris topher +1
    • Philipp Gampe +1
  • Verified V +2
    • Steffen Gebert +2
    • Chris topher +1
    • Philipp Gampe +1

Issues 1

Files 1

Review log 7

  1. Tolleiv Nietsch commented on patch set 1 06/23/11, 16:35

    Looks good to me, approved
  2. Stefan Neufeind commented on patch set 1 06/23/11, 16:35

    Looks good to me, but someone else must approve no-brainer :-)
  3. Steffen Gebert commented on patch set 1 V 0 06/23/11, 16:35

    by team member; Looks good to me, approved
  4. Chris topher commented on patch set 1 06/23/11, 16:35

    Verified; Looks good to me, but someone else must approve
  5. Philipp Gampe commented on patch set 1 06/23/11, 16:35

    Verified; Looks good to me, but someone else must approve
  6. Mr. Jenkins commented on patch set 1 06/23/11, 16:35

  7. Steffen Gebert merged patch set 1 06/23/11, 16:35