28670[TASK] Add 'tx_extbase_type' to model Category
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 3
Review log 13
-
Mr. Jenkins commented on patch set 1 03/23/14, 15:42
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15571/ : SUCCESS -
Philipp Gampe commented on patch set 1 03/23/14, 15:56
ext_tables.php:75this does forcely override the first type, doesn't it? -
Philipp Gampe commented on patch set 1 CR +1 03/23/14, 15:58
ext_tables.php:75Replynever mind -
Nico de Haen commented on patch set 1 03/23/14, 16:00
ext_tables.php:75ReplyNo, it only sets the key "'Tx_Extbase_Domain_Model_Category'", if there are other keys they won't be overridden -
Xavier Perseguers commented on patch set 1 CR -1 03/23/14, 16:11
Wonder how you ended up having visible labels with your patchlocallang_db.xlf:15you need to copy this one for sys_categorylocallang_db.xlf:18you need to copy this one for sys_categorylocallang_db.xlf:24Invalid localization key, should be "sys_category.tx_extbase..." -
Stefan Neufeind uploaded patch set 2 03/23/14, 16:18
-
Stefan Neufeind commented on patch set 2 03/23/14, 16:19
@Xavier: thanks for the fix-hints -
Mr. Jenkins commented on patch set 2 03/23/14, 16:31
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15574/ : SUCCESS -
Xavier Perseguers voted on patch set 2 V +1 CR +1 03/23/14, 16:32
-
Marc Bastian Heinrichs commented on patch set 2 CR -1 03/23/14, 16:39
The field in users and groups was only left for combability reasons. see removent patch: https://review.typo3.org/#/c/17879/ they are not needed per default anymore. Don't add this for Category as "tx_extbase_type"! In users and groups this was integrated as example for Single Table Interitence which causes more trouble than it helps. If you need STI for Category you should implement it on your own. And the extbase Cateory Model is only experimental ATM, because it doesn't has all feature, that would be needed for a fully integration. And why a default type field should be shipped? Makes only for me sense if you also have a category type record. But there is usage for this ATM. -
Christian Kuhn commented on patch set 2 CR -1 03/23/14, 16:45
what maba said. -
Helmut Hummel commented on patch set 2 CR -1 03/23/14, 17:21
I agree with maba and christian. please abandon -
Stefan Neufeind abandoned the change 03/23/14, 17:35