Review main Abandoned

28670[TASK] Add 'tx_extbase_type' to model Category

Stefan Neufeind CR 0 V 0 Easy +38 −0 updated 03/23/14, 17:35

Commit message

Same type-field like there is for fe_users and fe_groups already.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 13

  1. Mr. Jenkins commented on patch set 1 03/23/14, 15:42

  2. Philipp Gampe commented on patch set 1 03/23/14, 15:56

    ext_tables.php:75

    this does forcely override the first type, doesn't it?
  3. Philipp Gampe commented on patch set 1 CR +1 03/23/14, 15:58

    ext_tables.php:75 Reply

    never mind
  4. Nico de Haen commented on patch set 1 03/23/14, 16:00

    ext_tables.php:75 Reply

    No, it only sets the key "'Tx_Extbase_Domain_Model_Category'", if there are other keys they won't be overridden
  5. Xavier Perseguers commented on patch set 1 CR -1 03/23/14, 16:11

    Wonder how you ended up having visible labels with your patch

    locallang_db.xlf:15

    you need to copy this one for sys_category

    locallang_db.xlf:18

    you need to copy this one for sys_category

    locallang_db.xlf:24

    Invalid localization key, should be "sys_category.tx_extbase..."
  6. Stefan Neufeind uploaded patch set 2 03/23/14, 16:18

  7. Stefan Neufeind commented on patch set 2 03/23/14, 16:19

    @Xavier: thanks for the fix-hints
  8. Mr. Jenkins commented on patch set 2 03/23/14, 16:31

  9. Xavier Perseguers voted on patch set 2 V +1 CR +1 03/23/14, 16:32

  10. Marc Bastian Heinrichs commented on patch set 2 CR -1 03/23/14, 16:39

    The field in users and groups was only left for combability reasons. see removent patch: https://review.typo3.org/#/c/17879/ they are not needed per default anymore. Don't add this for Category as "tx_extbase_type"! In users and groups this was integrated as example for Single Table Interitence which causes more trouble than it helps. If you need STI for Category you should implement it on your own. And the extbase Cateory Model is only experimental ATM, because it doesn't has all feature, that would be needed for a fully integration. And why a default type field should be shipped? Makes only for me sense if you also have a category type record. But there is usage for this ATM.
  11. Christian Kuhn commented on patch set 2 CR -1 03/23/14, 16:45

    what maba said.
  12. Helmut Hummel commented on patch set 2 CR -1 03/23/14, 17:21

    I agree with maba and christian. please abandon
  13. Stefan Neufeind abandoned the change 03/23/14, 17:35