Review main Merged

28683[BUGFIX] Unresolvable dependency if composer.json lacks version

Claus Due CR +2 V +2 Easy +6 −1 updated 03/24/14, 12:33

Commit message

This change fixes a problem which occurs under these circumstances:

* Extension A depends on Extension B
* Extension B is currently installed
* Extension A is not currently installed
* Extension B has composer.json file
* Extension B composer.json file contains no "version" attribute
  or this attribute is empty.

When installing Extension A in this case, EM will fail with an
error saying "could not resolve dependency for xyz" which is a
bit too vague to be helpful. This change fixes this murky error
by throwing a much more specific error saying exactly that the
error stems from the composer.json file missing a "version" no.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1