Review main Abandoned

28729[BUGFIX] Extracting t3x tries to do a "writeFile" on directories

Ernesto Baschny CR 0 V 0 Easy +4 −0 updated 03/25/14, 00:27

Commit message

Directories are first created, then files extracted into them. But
the loop going over FILES does not check for directories. Same
check the other way around can already be found in
extractDirectoriesFromExtensionData where the directory list is
created.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 5

  1. Ernesto Baschny uploaded patch set 2 03/24/14, 21:52

  2. Mr. Jenkins commented on patch set 1 03/24/14, 23:01

  3. Benni Mack voted on patch set 2 CR +1 03/24/14, 23:11

  4. Mr. Jenkins commented on patch set 2 03/24/14, 23:14

  5. Ernesto Baschny abandoned the change 03/25/14, 00:27

    Much cleaner solution from Helmut: https://review.typo3.org/#/c/28731/