Review main Merged

28777[TASK] Fix a PHP warning in Clipboard

Georg Ringer CR +2 V +2 Easy +1 −1 updated 03/25/14, 16:13

Commit message

Check if the key is available.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Oliver Klee +1
    • Alexander Stehlik +1
    • Sebastian Fischer +1
  • Verified V +2
    • Georg Ringer +2

Issues 1

Files 1

Review log 8

  1. Alexander Stehlik voted on patch set 1 CR +1 03/25/14, 15:52

  2. Sebastian Fischer voted on patch set 1 CR +1 03/25/14, 15:52

  3. Oliver Klee commented on patch set 1 CR -1 03/25/14, 15:54

    The is_array needs to come first, before the isset.
  4. Alexander Stehlik commented on patch set 1 03/25/14, 15:55

    What? Why is that? First you check if the element is present, then you check if it is an array...
  5. Mr. Jenkins commented on patch set 1 03/25/14, 15:59

  6. Oliver Klee commented on patch set 1 CR +1 03/25/14, 16:09

    Oh, sorry, I misread the code. It actually seems to be okay.
  7. Georg Ringer voted on patch set 1 V +2 CR +2 03/25/14, 16:13

  8. Georg Ringer merged patch set 2 03/25/14, 16:13