Review main Merged

2882[BUGFIX] getProcessedValue ignores sorting of select field values

Johannes Feustel CR +2 V +2 Easy +5 −1 updated 11/10/13, 13:28

Commit message

Keep sorting of select field values which is lost during database select.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Markus Klein +1
  • Verified V +2
    • Stefan Neufeind +2
    • Markus Klein +1

Files 1

Review log 52

Show 27 earlier messages
  1. Gerrit wrote 05/27/13, 17:19

    Your change could not be merged due to a path conflict. Please merge (or rebase) the change locally and upload the resolution for review.
  2. Stefan Neufeind commented on patch set 1 05/27/13, 17:19

    Looks good to me, but someone else must approve
  3. Stefan Neufeind uploaded patch set 3 05/27/13, 17:19

  4. Stefan Neufeind commented on patch set 3 05/27/13, 17:19

    Looks good to me, but someone else must approve Just rebased and commit-message adjusted for 4.7. Had before: V:2x +1, R:2x +1
  5. Stefan Neufeind commented on patch set 3 05/27/13, 17:19

    Counting again :-) Had before: V:1x +1, R:2x +1
  6. Markus Klein commented on patch set 3 05/27/13, 17:19

    (1 inline comment) Please fix commit message,, again ;-)
    Fixes:
  7. Markus Klein commented on patch set 3 05/27/13, 17:19

    Will fix it! (And also the newline at the end)
  8. Stefan Neufeind commented on patch set 4 05/27/13, 17:19

    Looks good to me, but someone else must approve regiving vote
  9. Stefan Neufeind commented on patch set 4 05/27/13, 17:19

    (1 inline comment)
  10. Markus Klein commented on patch set 4 05/27/13, 17:19

    Has before: V:+1; 3x R:+1
  11. Markus Klein uploaded patch set 4 05/27/13, 17:19

  12. Markus Klein commented on patch set 4 05/27/13, 17:19

    Verified; Looks good to me, but someone else must approve Votes reflecting old votes: V:+1; 3x R:+1
  13. Stefan Neufeind commented on patch set 5 05/27/13, 17:19

    Looks good to me, but someone else must approve
  14. Stefan Neufeind uploaded patch set 6 05/27/13, 17:19

  15. Stefan Neufeind commented on patch set 6 05/27/13, 17:19

    please have another look. Just moved the patched lines to the correct location - not tested (sorry)
  16. Markus Klein uploaded patch set 5 05/27/13, 17:19

  17. Markus Klein commented on patch set 5 05/27/13, 17:19

    Verified; Looks good to me, but someone else must approve Rebased for 6.0
  18. Oliver Hader uploaded patch set 2 05/27/13, 17:19

  19. Oliver Hader commented on patch set 2 05/27/13, 17:19

    Looks good to me, but someone else must approve Rebasing to master V:0, R:1 V:0, R:1 from Stefan Neufeind <typo3.neufeind@speedpartner.de>
  20. Oliver Hader commented on patch set 5 05/27/13, 17:19

    Steffen, the file-name is wrong (before namespace introduction)
  21. Georg Ringer commented on patch set 5 05/27/13, 17:19

    Looks good to me, but someone else must approve
  22. Steffen Ritter commented on patch set 4 05/27/13, 17:19

    Looks good to me, but someone else must approve
  23. Steffen Ritter commented on patch set 5 05/27/13, 17:19

    Verified; Looks good to me, approved
  24. Steffen Ritter commented on patch set 5 V 0 05/27/13, 17:19

    by team member
  25. Johannes Feustel commented on patch set 2 05/27/13, 17:19

    Verified; Looks good to me, but someone else must approve
  26. Johannes Feustel commented on patch set 6 05/27/13, 17:19

    Fails; I would prefer that you didn't submit this Patch Set 6 misses the essential ksort($mmlA); and contains superfluous + pasted from patch file probably. @Philipp see screenshots on forge.
  27. Stefan Neufeind commented on patch set 7 05/27/13, 17:19

    thanks for spotting/fixing the missing ksort()
  1. Markus Klein uploaded patch set 8 05/27/13, 17:19

  2. Markus Klein commented on patch set 8 05/27/13, 17:19

    Rebased for 6.1
  3. Markus Klein commented on patch set 8 05/27/13, 17:19

    Looks good to me, but someone else must approve
  4. Johannes Feustel uploaded patch set 7 05/27/13, 17:19

  5. Philipp Gampe commented on patch set 6 05/27/13, 17:19

    I don't get it, how do I reproduce this?
  6. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  7. Mr. Jenkins commented on patch set 2 05/27/13, 17:19

  8. Mr. Jenkins commented on patch set 3 05/27/13, 17:19

  9. Mr. Jenkins commented on patch set 4 05/27/13, 17:19

  10. Mr. Jenkins commented on patch set 5 05/27/13, 17:19

  11. Mr. Jenkins commented on patch set 6 05/27/13, 17:19

  12. Mr. Jenkins commented on patch set 7 05/27/13, 17:19

  13. Mr. Jenkins commented on patch set 8 05/27/13, 17:19

  14. Wouter Wolters commented on patch set 5 05/27/13, 17:19

    Looks good to me, but someone else must approve
  15. Markus Klein uploaded patch set 9 06/04/13, 22:49

  16. Markus Klein commented on patch set 9 CR +1 06/04/13, 22:49

    6.2 rebase
  17. Stefan Neufeind commented on patch set 9 CR +1 06/05/13, 06:32

    add 6.0
  18. Markus Klein uploaded patch set 10 07/16/13, 22:54

  19. Markus Klein commented on patch set 10 CR +1 07/16/13, 22:54

    Rebased
  20. Mr. Jenkins commented on patch set 10 07/16/13, 22:55

  21. Markus Klein rebased onto patch set 10 11/10/13, 11:50

  22. Markus Klein voted on patch set 11 V +1 CR +1 11/10/13, 11:50

  23. Mr. Jenkins commented on patch set 11 11/10/13, 12:06

  24. Stefan Neufeind voted on patch set 11 V +2 CR +2 11/10/13, 13:28

  25. Stefan Neufeind merged patch set 12 11/10/13, 13:28