2882[BUGFIX] getProcessedValue ignores sorting of select field values
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Markus Klein +1
-
Verified V +2
- Stefan Neufeind +2
- Markus Klein +1
Files 1
Review log 52
Show 27 earlier messages
-
Gerrit wrote 05/27/13, 17:19
Your change could not be merged due to a path conflict. Please merge (or rebase) the change locally and upload the resolution for review. -
Stefan Neufeind commented on patch set 1 05/27/13, 17:19
Looks good to me, but someone else must approve -
Stefan Neufeind uploaded patch set 3 05/27/13, 17:19
-
Stefan Neufeind commented on patch set 3 05/27/13, 17:19
Looks good to me, but someone else must approve Just rebased and commit-message adjusted for 4.7. Had before: V:2x +1, R:2x +1 -
Stefan Neufeind commented on patch set 3 05/27/13, 17:19
Counting again :-) Had before: V:1x +1, R:2x +1 -
Markus Klein commented on patch set 3 05/27/13, 17:19
(1 inline comment) Please fix commit message,, again ;-)Fixes: -
Markus Klein commented on patch set 3 05/27/13, 17:19
Will fix it! (And also the newline at the end) -
Stefan Neufeind commented on patch set 4 05/27/13, 17:19
Looks good to me, but someone else must approve regiving vote -
Stefan Neufeind commented on patch set 4 05/27/13, 17:19
(1 inline comment) -
Markus Klein commented on patch set 4 05/27/13, 17:19
Has before: V:+1; 3x R:+1 -
Markus Klein uploaded patch set 4 05/27/13, 17:19
-
Markus Klein commented on patch set 4 05/27/13, 17:19
Verified; Looks good to me, but someone else must approve Votes reflecting old votes: V:+1; 3x R:+1 -
Stefan Neufeind commented on patch set 5 05/27/13, 17:19
Looks good to me, but someone else must approve -
Stefan Neufeind uploaded patch set 6 05/27/13, 17:19
-
Stefan Neufeind commented on patch set 6 05/27/13, 17:19
please have another look. Just moved the patched lines to the correct location - not tested (sorry) -
Markus Klein uploaded patch set 5 05/27/13, 17:19
-
Markus Klein commented on patch set 5 05/27/13, 17:19
Verified; Looks good to me, but someone else must approve Rebased for 6.0 -
Oliver Hader uploaded patch set 2 05/27/13, 17:19
-
Oliver Hader commented on patch set 2 05/27/13, 17:19
Looks good to me, but someone else must approve Rebasing to master V:0, R:1 V:0, R:1 from Stefan Neufeind <typo3.neufeind@speedpartner.de> -
Oliver Hader commented on patch set 5 05/27/13, 17:19
Steffen, the file-name is wrong (before namespace introduction) -
Georg Ringer commented on patch set 5 05/27/13, 17:19
Looks good to me, but someone else must approve -
Steffen Ritter commented on patch set 4 05/27/13, 17:19
Looks good to me, but someone else must approve -
Steffen Ritter commented on patch set 5 05/27/13, 17:19
Verified; Looks good to me, approved -
Steffen Ritter commented on patch set 5 V 0 05/27/13, 17:19
by team member -
Johannes Feustel commented on patch set 2 05/27/13, 17:19
Verified; Looks good to me, but someone else must approve -
Johannes Feustel commented on patch set 6 05/27/13, 17:19
Fails; I would prefer that you didn't submit this Patch Set 6 misses the essential ksort($mmlA); and contains superfluous + pasted from patch file probably. @Philipp see screenshots on forge. -
Stefan Neufeind commented on patch set 7 05/27/13, 17:19
thanks for spotting/fixing the missing ksort()
-
Markus Klein uploaded patch set 8 05/27/13, 17:19
-
Markus Klein commented on patch set 8 05/27/13, 17:19
Rebased for 6.1 -
Markus Klein commented on patch set 8 05/27/13, 17:19
Looks good to me, but someone else must approve -
Johannes Feustel uploaded patch set 7 05/27/13, 17:19
-
Philipp Gampe commented on patch set 6 05/27/13, 17:19
I don't get it, how do I reproduce this? -
Mr. Jenkins commented on patch set 1 05/27/13, 17:19
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/789/ : SUCCESS -
Mr. Jenkins commented on patch set 2 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2711/ : SUCCESS -
Mr. Jenkins commented on patch set 3 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2821/ : SUCCESS -
Mr. Jenkins commented on patch set 4 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2822/ : SUCCESS -
Mr. Jenkins commented on patch set 5 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5238/ : SUCCESS -
Mr. Jenkins commented on patch set 6 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6619/ : SUCCESS -
Mr. Jenkins commented on patch set 7 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6625/ : SUCCESS -
Mr. Jenkins commented on patch set 8 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7544/ : SUCCESS -
Wouter Wolters commented on patch set 5 05/27/13, 17:19
Looks good to me, but someone else must approve -
Markus Klein uploaded patch set 9 06/04/13, 22:49
-
Markus Klein commented on patch set 9 CR +1 06/04/13, 22:49
6.2 rebase -
Stefan Neufeind commented on patch set 9 CR +1 06/05/13, 06:32
add 6.0 -
Markus Klein uploaded patch set 10 07/16/13, 22:54
-
Markus Klein commented on patch set 10 CR +1 07/16/13, 22:54
Rebased -
Mr. Jenkins commented on patch set 10 07/16/13, 22:55
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9646/ : SUCCESS -
Markus Klein rebased onto patch set 10 11/10/13, 11:50
-
Markus Klein voted on patch set 11 V +1 CR +1 11/10/13, 11:50
-
Mr. Jenkins commented on patch set 11 11/10/13, 12:06
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11947/ : SUCCESS -
Stefan Neufeind voted on patch set 11 V +2 CR +2 11/10/13, 13:28
-
Stefan Neufeind merged patch set 12 11/10/13, 13:28