Review main Merged

28900[TASK] HMENU: Extract menu item generation into separate methods

Benni Mack CR +2 V +2 Expert +645 −474 updated 01/03/15, 14:20

Commit message

In order to ensure valid options and consistency, the 500+ lines
of code for generating special=XY menus in HMENU
can be safely moved into separate methods within the same
class. Additionally, when subclassing HMENU, the functions
can be overridden easier.

The makeMenu() function gets smaller and the new methods are
a good target for creating unit tests.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1