Review main Merged

29057[BUGFIX] Improve Windows support for functional tests

Nicole Hummel CR +2 V +2 Easy +30 −11 updated 05/03/14, 21:14

Commit message

Solve some issues running function tests on windows OS

* Disable colors, this is hardly supported in windows CLI,
  enable in .travis.yml explicitly
* Convert the web root path into a unix styled one to prevent a
  mix between backslashes and forward slashes
* Improve finding the PHP binary as the system constants PHP_BINDIR
  is defined with "C:\php" even if PHP is installed in a different folder
* Improves command line argument escaping for special windows
  requirements.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5