29202[BUGFIX] ResourceStorage does not sanitize folder/file name
Commit message
Review
-
Code review CR +2
- Francois Suter +2
- Stefan Neufeind +1
- Alexander Opitz +1
- Stefan Froemken +1
-
Verified V +2
- Francois Suter +2
- Alexander Opitz +1
- Stefan Froemken +1
Issues 1
Files 1
Review log 25
-
Mr. Jenkins commented on patch set 1 04/06/14, 09:44
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15896/ : SUCCESS -
Frans Saris uploaded patch set 2 04/07/14, 18:17
-
Mr. Jenkins commented on patch set 2 04/07/14, 18:30
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15912/ : SUCCESS -
Markus Klein commented on patch set 2 04/07/14, 18:40
ResourceStorage.php:1726can be reduced to ?: -
Markus Klein voted on patch set 2 V +1 CR +1 04/07/14, 18:50
-
Stefan Neufeind commented on patch set 2 04/13/14, 10:16
ResourceStorage.php:1726Replysure. please do before commit -
Oliver Klee commented on patch set 2 CR -1 04/13/14, 10:20
Coming up with a new patch in a minute.typo: sanitezed -> sanitizedResourceStorage.php:1824We should have a different name for this variable. Otherwise, you need to remember on reading which newName the code currently is about. (Overwriting parameters is a Code Smell, btw.) -
Oliver Klee uploaded patch set 3 04/13/14, 10:29
-
Oliver Klee commented on patch set 3 04/13/14, 10:29
Fixed the comments. -
Mr. Jenkins commented on patch set 3 04/13/14, 10:42
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15982/ : SUCCESS -
Stefan Froemken uploaded patch set 4 04/15/14, 13:10
-
Oliver Klee voted on patch set 4 CR +1 04/15/14, 13:12
-
Stefan Froemken commented on patch set 4 04/15/14, 13:15
I wonder a bit about the sanitize-process: Rename "Frömken.jpg" results in "froemken.jpg". Copy/Move a file called "Frömken.jpg" results in "fro__mken.jpg" in the other folder. -
Mr. Jenkins commented on patch set 4 04/15/14, 13:24
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16019/ : SUCCESS -
Stefan Froemken voted on patch set 4 V +1 CR +1 04/15/14, 16:30
-
Stefan Neufeind commented on patch set 4 CR +1 04/15/14, 16:34
it says this needs a rebase. Should be good to go then imho. -
Frans Saris commented on patch set 4 04/15/14, 17:33
will push rebased patch -
Frans Saris uploaded patch set 5 04/15/14, 17:41
-
Mr. Jenkins commented on patch set 5 04/15/14, 17:54
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16026/ : SUCCESS -
Stefan Froemken voted on patch set 5 V +1 CR +1 04/16/14, 06:42
-
Stefan Neufeind voted on patch set 5 CR +1 04/16/14, 07:10
-
Alexander Opitz voted on patch set 5 V +1 CR +1 04/16/14, 11:18
-
Frans Saris commented on patch set 5 04/16/14, 16:53
Some test cases: renaming a folder named "test" to "test 2" (after patch this should not give an error anymore) add a file through ftp/ssh with spaces in the name go to filemodule and copy/paste the file (after patch filename should be sanitized) add a file through ftp/ssh with spaces in the name go to filemodule and move the file (after patch filename should be sanitized) add a file through ftp/ssh with spaces in the name go to filemodule and renaming the file (after patch filename should be sanitized even if you try to rename to filename with spaces) add a file through ftp/ssh with spaces in the name go to filemodule and copy/paste the folder (after patch foldername should be sanitized) add a folder through ftp/ssh with spaces in the name go to filemodule and move the folder (after patch foldername should be sanitized) -
Francois Suter voted on patch set 5 V +2 CR +2 04/16/14, 19:36
-
Francois Suter merged patch set 6 04/16/14, 19:36