29535[BUGFIX] Respect absRefPrefix in admin panel
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Michael Oehlhof +1
- Mathias Brodala +1
-
Verified V +2
- Christian Kuhn +2
- Michael Oehlhof +1
Issues 1
Files 1
Review log 39
Show 14 earlier messages
-
Mr. Jenkins commented on patch set 1 04/17/14, 09:17
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16045/ : SUCCESS -
Wouter Wolters voted on patch set 1 CR +1 04/22/14, 21:18
-
Jan Kiesewetter voted on patch set 1 V +1 CR +1 04/24/14, 06:38
-
Dmitry Dulepov commented on patch set 1 CR -1 05/05/14, 12:21
Please, check the comment.TimeTracker.php:143Why is this removed? This leaves variables initialized incorrectly. -
Wouter Wolters commented on patch set 1 05/05/14, 12:25
TimeTracker.php:143ReplyThis is moved to the start() function, not removed;) -
Alexander Stehlik rebased onto patch set 1 09/30/14, 20:24
-
Alexander Stehlik updated the commit message in patch set 3 09/30/14, 20:24
-
Stefan Froemken voted on patch set 3 CR +1 10/03/14, 01:33
-
Alexander Stehlik updated the commit message in patch set 4 11/16/14, 14:38
-
Michael Oehlhof uploaded patch set 5 04/24/15, 19:10
-
Michael Oehlhof commented on patch set 5 04/24/15, 19:56
Rebased to solve the merge conflict. -
Cedric Ziel voted on patch set 5 CR +1 04/25/15, 09:27
-
Benni Mack voted on patch set 5 CR +1 V +1 05/08/15, 02:45
-
Cedric Ziel voted on patch set 5 V +1 05/08/15, 07:56
-
Frank Nägler commented on patch set 5 CR -1 05/08/15, 18:23
please use htmlspecialchars, I have commented all lines where the generated output is not escaped.TimeTracker.php:147please use htmlspecialcharsTimeTracker.php:148please use htmlspecialcharsTimeTracker.php:149please use htmlspecialcharsTimeTracker.php:206please use htmlspecialcharsTimeTracker.php:448please use htmlspecialcharsTimeTracker.php:453please use htmlspecialcharsAdminPanelView.php:284please use htmlspecialcharsAdminPanelView.php:407please use htmlspecialchars -
Christian Kuhn commented on patch set 5 CR -1 05/08/15, 21:54
frankies htmlspecialchars comments are valid. other than that the further public method doesn't make the 'API' more beautiful, but ... well ... go ahead with that ... -
Christian Kuhn commented on patch set 5 05/08/15, 21:56
imho this patch is not really important enough for 6.2 - the risk for a regression / sec issue is too high, from my point of view in comparison with some maybe missing images - especially since this bug is probably very old already. thus, i'd not backport this to 6.2, except good reasons pop up to do so. -
Christian Kuhn updated the commit message in patch set 6 05/08/15, 21:56
-
Frank Nägler commented on patch set 6 CR -1 05/08/15, 21:57
on it, fixing the hsc thingy -
Frank Nägler uploaded patch set 7 05/08/15, 22:03
-
Christian Kuhn commented on patch set 7 05/08/15, 22:50
Hey, I'm still not really sure about 6.2 and tried to reproduce the issue to get an overview about the impact. But I'm unable to trigger the issue - no matter what I do, the images (like the tree stuff in the admin panel) always loads with correct paths, also with realurl and an installation in a sub-path ... So, either I get a TS snipped and more detailled instructions on how to reproduce the issue, or someone else needs to step in here, which would be great. -
Alexander Stehlik commented on patch set 5 07/02/15, 18:11
I have submitted a TYPO3 6.2 patch to make testing easier: https://review.typo3.org/#/c/40867/ I also added detailed steps to reproduce the problem in the issue: https://forge.typo3.org/issues/52211 I'll now test the master. I think the problem there is not as bad because most of the icons were replaced with sprites. Maybe we can just backport that... -
Alexander Stehlik commented on patch set 5 07/02/15, 18:37
Just tested current master. Almost all of the problems from 6.2 are still there. Only the error icons in TimeTracker::setTSlogMessage() were replaced with sprites. -
Alexander Stehlik uploaded patch set 8 07/02/15, 18:48
-
Alexander Stehlik uploaded patch set 9 07/02/15, 18:50
-
Alexander Stehlik commented on patch set 9 07/02/15, 18:53
Anyone an idea how to fix / get rid of the clear.gif in TimeTracker::setTSlogMessage()? The problem here is that the method is called quite early where the image path prefix is not initialized. -
Benni Mack commented on patch set 9 08/12/15, 19:21
Hey Alex, care to update your patch? Seems like we only need 1 part (the JS file) now linked to it in v7. -
Stefan Neufeind commented on patch set 9 08/12/15, 23:46
@Alex: There is no clear.gif anymore in current master. (We'd need a solution for the backport though - or we don't backport it.) -
Daniel Goerz commented on patch set 9 08/23/15, 11:20
What is the status here? -
Alexander Stehlik commented on patch set 9 09/13/15, 20:38
Remaining problem in current master is the integration of the jsfunc.evalfield.js file. Since this is only a cosmetic problem I would not backport it to 6.2. -
Alexander Stehlik uploaded patch set 10 09/13/15, 20:53
-
Mathias Brodala voted on patch set 10 CR +1 09/13/15, 20:55
-
Daniel Goerz commented on patch set 10 09/13/15, 21:35
AdminPanelView.php:287There is a getTypoScriptFrontendController() method that should rather be used. -
Alexander Stehlik uploaded patch set 11 09/14/15, 07:54
-
Alexander Stehlik commented on patch set 10 09/14/15, 07:54
AdminPanelView.php:287ReplyGood point, thanks! -
Mathias Brodala voted on patch set 11 CR +1 09/14/15, 07:59
-
Michael Oehlhof voted on patch set 11 CR +1 V +1 09/15/15, 10:27
-
Christian Kuhn voted on patch set 11 CR +2 V +2 09/15/15, 10:31
-
Christian Kuhn merged patch set 11 09/15/15, 10:31