Review main Merged

29580Revert "[BUGFIX] Do not reset Page Renderer on partial rendering"

Helmut Hummel CR +2 V +2 Normal +2 −54 updated 04/22/14, 19:54

Commit message

The page renderer is not designed to work with
a second rendering pass without resetting to its initial state.

Not resetting will cause double compression of files and
creating wrong version numbered file names.

Reverting this again means: ->addFooter* calls are ignored
when being called before first rendering pass and
only work when done after first rendering pass.

Although this behavior is highly intransparent
it cannot easily be fixed without heavy refactoring
of the page renderer which most likely will break hooks.

Introduced regression by this change: #57919 and #58010

This reverts commit c67e8ebbb074c46dae40bec329db7392e023b0d6

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Files 2