Review TYPO3_6-1 Merged

29883[BUGFIX] DependencyUtility does count() on an integer

Stefan Neufeind CR +2 V +2 Easy +6 −3 updated 05/14/14, 08:55

Commit message

Remove the superfluous count() call.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Markus Klein +1
    • Nicole Hummel +1
  • Verified V +2
    • Helmut Hummel +2
    • Stefan Neufeind +1
    • Nicole Hummel +1

Issues 1

Files 2

Review log 6

  1. Stefan Neufeind commented on patch set 1 V +1 05/05/14, 21:57

    Test handpicked to apply cleanly. Tests run fine here.
  2. Stefan Neufeind commented on patch set 1 05/05/14, 21:58

    Cherry Picked This patchset was cherry picked to change: I0933650b52063009de52268034480f6e06af56ac
  3. Markus Klein commented on patch set 1 CR +1 05/05/14, 22:34

    unit tests are not running for me on 6.1 currently, (TYPO3\CMS\Core\Tests\UnitTestCase not found) so I can't run the tests.
  4. Nicole Hummel commented on patch set 1 V +1 CR +1 05/05/14, 23:15

    Not sure about merge freeze
  5. Helmut Hummel voted on patch set 1 V +2 CR +2 05/14/14, 08:55

  6. Helmut Hummel merged patch set 2 05/14/14, 08:55