Review main Merged

29923[BUGFIX] Make object access work with ObjectStorage

Helmut Hummel CR +2 V +2 Normal +42 −21 updated 06/02/14, 16:29

Commit message

ObjectAccess->getPropertyPath() does not work with
ObjectStorage and numerical indexes, but it should be
because without it form fluid fields cannot be
properly handled as the value is always null.

Fixing fetching objects from ObjectStorage by index
will also enable shorter access of single objects in Fluid.

Imagine you want to render the first image in your
template. Previously you had to write this:

<f:for each="{object.images}" as="image" iteration="iterator">
	<f:if condition="{iterator.isFirst}">
		<f:image image="{image}" alt="" width="50"/>
	</f:if>
</f:for>

Now you can just write:

<f:image image="{object.images.0}" alt="" width="50"/>

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 2