Review main Abandoned

30233[BUGFIX] show_item does not properly resolve inline items

Xavier Perseguers CR 0 V 0 Easy +9 −1 updated 07/07/14, 06:28

Commit message

When using inline records, the column's value contains the number
of children and not a comma-separated list of uids.

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 14

  1. Mr. Jenkins commented on patch set 1 05/20/14, 09:24

  2. Oliver Hader commented on patch set 1 CR -1 05/22/14, 11:48

    Albeit inline values are shown correctly, MM values aren't anymore with this patch (e.g. test with the categories field).
  3. Xavier Perseguers commented on patch set 1 05/22/14, 12:40

    ElementInformationController.php:163

    This code had in fact no effect, it can be removed altogether, output stays the same

    ElementInformationController.php:163

    @Olly, confirmed! it breaks MM because now this code actually does something :)
  4. Xavier Perseguers commented on patch set 1 05/22/14, 12:44

    MM is not really broken, value is set but in case of MM, fields are not listed in the list of fields but shown afterwards into a "related records" table. With the patch, now doing something with the previous useless piece of code, MM are resolved and thus not detected anymore for the related records and as MM fields are not shown, info seems to have vanish.
  5. Xavier Perseguers uploaded patch set 2 05/22/14, 13:19

  6. Xavier Perseguers commented on patch set 2 05/22/14, 13:22

    BackendUtility.php:2097

    we wouldn't need anything more than the 'uid' column here...
  7. Mr. Jenkins commented on patch set 2 05/22/14, 13:44

  8. Tymoteusz Motylewski commented on patch set 2 05/22/14, 14:05

    BackendUtility.php:2098

    getRecordsByField() might also return null, so we have to add a check to avoid warnings.
  9. Oliver Hader commented on patch set 2 CR -1 05/22/14, 14:08

    It looks like we need a general relation resolver for that... Steffen once kick-started something in that direction

    BackendUtility.php:2097

    This does not consider workspaces nor localization
  10. Oliver Hader commented on patch set 2 CR 0 05/22/14, 14:22

    Currently working and checking...
  11. Oliver Hader commented on patch set 2 CR -1 05/22/14, 14:43

    Ok, localization works, but modifying the localized data in workspaces shows duplicate record. Thus, I'd opt to rather use RelationHandler for resolving here...
  12. Oliver Hader commented on patch set 2 CR 0 07/02/14, 07:29

    Looks like this has been reworked and merged already in https://review.typo3.org/#/c/30967/3
  13. Markus Klein commented on patch set 2 CR -1 07/06/14, 22:10

    Xavier please check again. Thanks.
  14. Xavier Perseguers abandoned the change 07/07/14, 06:28

    In fact, this seems fine now with current TYPO3_6-2 and thus the other patch having been merged. Thanks.