Review main Merged

30328[BUGFIX] Fix RewriteRule for context to avoid HTTP 500

Armin Vieweg CR +2 V +2 Easy +3 −3 updated 06/24/14, 15:40

Commit message

The affected rules are those for TYPO3_CONTEXT.
These rules should just set the ENV variable,
but should not touch the URL.
According to apache httpd docs this has to be
indicated by using a dash.

Also unnecessary grouping in the regexp has been
removed.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Markus Klein +1
    • Armin Vieweg +1
  • Verified V +2
    • Helmut Hummel +2
    • Markus Klein +1

Issues 1

Files 1

Review log 16

  1. Mr. Jenkins commented on patch set 1 05/22/14, 14:23

  2. Markus Klein updated the commit message in patch set 1 05/22/14, 14:39

  3. Markus Klein voted on patch set 2 V +1 CR +1 05/22/14, 14:40

  4. Mr. Jenkins commented on patch set 2 05/22/14, 14:54

  5. Markus Klein updated the commit message in patch set 2 06/17/14, 23:39

  6. Markus Klein voted on patch set 3 V +1 CR +1 06/17/14, 23:39

  7. Mr. Jenkins commented on patch set 3 06/17/14, 23:57

  8. Armin Vieweg uploaded patch set 4 06/24/14, 14:38

  9. Markus Klein updated the commit message in patch set 4 06/24/14, 14:41

  10. Markus Klein voted on patch set 5 V +1 CR +1 06/24/14, 14:43

  11. Armin Vieweg voted on patch set 5 CR +1 06/24/14, 14:44

  12. Mr. Jenkins commented on patch set 4 06/24/14, 14:54

  13. Mr. Jenkins commented on patch set 5 06/24/14, 14:57

  14. Helmut Hummel voted on patch set 5 V +2 CR +2 06/24/14, 15:39

  15. Helmut Hummel merged patch set 6 06/24/14, 15:39

  16. Helmut Hummel commented on patch set 6 06/24/14, 15:40

    Cherry Picked This patchset was cherry picked to change: I56cadcfb3cfae0a0ee679c6886cda9f5498fc47c