Review main Merged

30498[BUGFIX] PAGE_TSCONFIG_ID is not visible in TCA wizards

Xavier Perseguers CR +2 V +2 Easy +14 −4 updated 06/11/14, 14:35

Commit message

The placeholder PAGE_TSCONFIG_ID may be used in a foreign_table_where
TCA condition but is not available as parameter when using a wizard
to create new records. This patch fixes this issue.

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Wouter Wolters +1
    • Marcin Sągol +1
    • Fabien Udriot +1
  • Verified V +2
    • Xavier Perseguers +2
    • Fabien Udriot +1

Files 2

Review log 24

  1. Markus Klein commented on patch set 1 05/31/14, 12:10

    AddController.php:114

    Please use strpos here, that is faster

    AddController.php:115

    (int) cast
  2. Markus Klein commented on patch set 1 05/31/14, 12:10

    will push an update
  3. Markus Klein uploaded patch set 2 05/31/14, 12:13

  4. Markus Klein voted on patch set 2 CR +1 05/31/14, 12:14

  5. Mr. Jenkins commented on patch set 1 05/31/14, 12:21

  6. Mr. Jenkins commented on patch set 2 05/31/14, 12:27

  7. Xavier Perseguers voted on patch set 2 V +1 CR +1 05/31/14, 12:30

  8. Wouter Wolters commented on patch set 2 06/05/14, 21:52

    Where is this documented, I had a look in the TCA ref but could not find a hint that is should work in params, only for the where clause.
  9. Xavier Perseguers commented on patch set 2 06/11/14, 08:44

    For the use case, it makes sense that it works with params as well, otherwise it is near to useless to have the option in the first place.
  10. Fabien Udriot voted on patch set 2 V +1 CR +1 06/11/14, 10:00

  11. Steffen Ritter commented on patch set 2 CR -1 06/11/14, 10:42

    please write an more elaborate commit message
  12. Xavier Perseguers commented on patch set 2 06/11/14, 11:49

    What about [BUGFIX] PAGE_TSCONFIG_ID is not visible in TCA wizards The placeholder PAGE_TSCONFIG_ID may be used in a foreign_table_where TCA condition but is not available as parameter when using a wizard to create new records. This patch fixes this issue.
  13. Wouter Wolters commented on patch set 2 06/11/14, 11:53

    I'm ok with that message. Please don't forget that this needs an update in the documentation or let me know where this is stated in the documentation.
  14. Xavier Perseguers commented on patch set 2 06/11/14, 12:12

  15. Xavier Perseguers updated the commit message in patch set 2 06/11/14, 12:13

  16. Mr. Jenkins commented on patch set 3 CR -1 V -1 06/11/14, 12:28

  17. Xavier Perseguers updated the commit message in patch set 3 06/11/14, 12:31

  18. Mr. Jenkins commented on patch set 4 06/11/14, 12:46

  19. Xavier Perseguers commented on patch set 4 V +1 CR +1 06/11/14, 12:49

    Voting again since the patch still comes from Steffen Kamper and only the commit message was adapted.
  20. Wouter Wolters voted on patch set 4 CR +1 06/11/14, 12:50

  21. Marcin Sągol voted on patch set 4 CR +1 06/11/14, 13:11

  22. Fabien Udriot voted on patch set 4 V +1 CR +1 06/11/14, 14:32

  23. Xavier Perseguers voted on patch set 4 V +2 CR +2 06/11/14, 14:35

  24. Xavier Perseguers merged patch set 5 06/11/14, 14:35