Review main Merged

30581[BUGFIX] getIndpEnv('TYPO3_SSL') fails to detect reverseProxyIp

Jan-Erik Revsbech CR +2 V +2 Easy +1 −1 updated 06/06/14, 09:38

Commit message

When running TYPO3 behind a reverse proxy, which also handles SSL,
the setting reverseProxySSL should check if the site is requested
from one of the reverse proxies in order to determine whether
the site is using SSL.

It incorrectly does this check via getIndpEnv('REMOTE_ADDR') which has
already translated the proxy IP to the end-users IP, thus always
returning FALSE.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1