Review main Merged

30657[BUGFIX] Erroneous date sorting in File List

Xavier Perseguers CR +2 V +2 Easy +1 −1 updated 06/11/14, 11:06

Commit message

The sorting by date fails in the Filelist module when more
than 9 files with the same date are found since the numerical
suffix used to avoid overwriting existing entries in the
sorting array is not properly padded.

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Francois Suter +1
    • Fabien Udriot +1
  • Verified V +2
    • Xavier Perseguers +2
    • Francois Suter +1
    • Fabien Udriot +1

Files 1

Review log 8

  1. Xavier Perseguers voted on patch set 1 V +1 CR +1 06/11/14, 09:43

  2. Francois Suter commented on patch set 1 V +1 CR +1 06/11/14, 09:55

    Thanks for picking this up. I was waiting for a bit of feedback before submitting myself :-)
  3. Mr. Jenkins commented on patch set 1 06/11/14, 09:57

  4. Xavier Perseguers commented on patch set 1 06/11/14, 10:13

    Your solution is the easiest one, since padding the counter to some width (with leading 0's) would make the code much harder to read or would need an additional temporary variable.
  5. Fabien Udriot voted on patch set 1 V +1 CR +1 06/11/14, 10:21

  6. Xavier Perseguers voted on patch set 1 V +2 CR +2 06/11/14, 10:30

  7. Xavier Perseguers merged patch set 2 06/11/14, 10:30

  8. Francois Suter commented on patch set 2 06/11/14, 11:06

    Thanks! I'll take care of the backport to 6.1, I need it for a client ;-)