Review main Merged

31082[BUGFIX] Bad index for determineSiteRoot

Stefan Froemken CR +2 V +2 Easy +1 −1 updated 12/14/14, 12:56

Commit message

Extbase in the backend fires a query to the pages table where
deleted=0 AND hidden=0 AND is_siteroot=1 ORDER BY sorting LIMIT 1

The patch changes an index that was added for this query to
reduce the result more quickly, with the assumption there is only a
very small number of is_siteroot=1 pages in comparison to deleted
and hidden pages. Also hidden and deleted are not any longer part
of the index, since order by sorting with limit 1 will break the
rest of the result set very early.

Target of the patch is master only since the 6.2 variant is not
that bad, so there is no urgend need to force people changing
indexes in 6.2 production systems.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1