Review main Abandoned

31086[BUGFIX] Add index for sys_language

Stefan Froemken CR 0 V 0 Easy +2 −1 updated 01/26/15, 19:25

Commit message

As all cols of sys_language are in sum 348 bytes
long we can add an index over all cols to
fetch data with help of USING INDEX

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 8

  1. Mr. Jenkins commented on patch set 1 06/23/14, 17:15

  2. Oliver Klee voted on patch set 1 CR +1 06/24/14, 07:49

  3. Marcin Sągol voted on patch set 1 CR +1 07/07/14, 22:31

  4. Stefan Neufeind commented on patch set 1 12/07/14, 15:51

    I don't think you'll have enough syslanguages that this actually makes a difference. And "blindly" adding an index across all columns isn't a good idea as well imho. You'll need to know what queries are fired on this table to see what order of fields makes sense in the key you create.
  5. Mathias Schreiber commented on patch set 1 12/07/14, 16:57

    Can you explain how the fetching gets faster? It sounds tempting but I can't find a source of info :)
  6. Stefan Neufeind voted on patch set 1 CR -1 12/07/14, 20:07

  7. Benni Mack commented on patch set 1 CR -1 01/11/15, 00:07

    ext_tables.sql:650

    I cannot recall any SQL queries thinking of pid, title, flag, and tstamp in sys_language. Also. please remove static_lang_isocode from the list (as we use the new field for that).
  8. Mathias Schreiber abandoned the change 01/26/15, 19:25

    no feedback given - abandoning