Review main Abandoned

31109[BUGFIX] Fix RewriteRule for context to avoid HTTP 500

Armin Vieweg CR 0 V 0 Easy +3 −3 updated 06/24/14, 14:41

Commit message

The affected rules are those for TYPO3_CONTEXT.
These rules should just set the ENV variable,
but should not touch the URL.
According to apache httpd docs this has to be
indicated by using a dash.

Also unnecessary grouping in the regexp has been
removed.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 10

  1. Armin Vieweg rebased onto patch set 1 06/24/14, 12:28

  2. Armin Vieweg updated the commit message in patch set 2 06/24/14, 12:31

  3. Armin Vieweg updated the commit message in patch set 3 06/24/14, 12:32

  4. Mr. Jenkins commented on patch set 1 06/24/14, 12:41

  5. Mr. Jenkins commented on patch set 2 06/24/14, 12:44

  6. Markus Klein commented on patch set 4 CR -1 06/24/14, 12:46

    Ehm I guess you wanted to push that over the other patch as new change set, right? Todo do so: * cherry-pick the original patch * modify the file * git commit -a --amend * git push origin HEAD:refs/for/master
  7. Mr. Jenkins commented on patch set 3 06/24/14, 12:56

  8. Mr. Jenkins commented on patch set 4 06/24/14, 12:59

  9. Armin Vieweg commented on patch set 4 V -1 CR -1 06/24/14, 14:41

    Thank you! I wasn't able to commit -a with the cherry pick. But it was possible with a whole checkout of the branch. How ever the changes are now in the correct thread. So this may be closed.
  10. Armin Vieweg abandoned the change 06/24/14, 14:41

    Wrong thread.