31197[BUGFIX] Let live search use getRecordTitle
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Nicole Hummel +2
- Marcin Sągol +1
- Anja Leichsenring +1
- Helmut Hummel +1
-
Verified V +2
- Christian Kuhn +2
- Nicole Hummel +2
- Marcin Sągol +1
Issues 2
Files 1
Review log 20
-
Mr. Jenkins commented on patch set 1 CR -1 V -1 06/28/14, 17:24
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/17081/ : FAILURE -
Marcin Sągol commented on patch set 1 V +1 CR +1 06/28/14, 17:37
Works fine for me on TYPO3 6.2.3 :)Thank you Markus. -
Markus Klein uploaded patch set 2 06/28/14, 18:09
-
Markus Klein commented on patch set 2 06/28/14, 18:10
Removed the method I forgot to do so earlier. -
Marcin Sągol voted on patch set 2 V +1 CR +1 06/28/14, 18:13
-
Markus Klein updated the commit message in patch set 2 06/28/14, 18:20
-
Marcin Sągol voted on patch set 3 V +1 CR +1 06/28/14, 18:21
-
Mr. Jenkins commented on patch set 2 06/28/14, 18:24
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/17084/ : SUCCESS -
Mr. Jenkins commented on patch set 3 06/28/14, 18:37
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/17085/ : SUCCESS -
Marcin Sągol commented on patch set 3 06/29/14, 22:05
Ping. Please don't forget about this patch for the next bugfix release of 6.2 series :) -
Nicole Hummel voted on patch set 3 CR +2 06/30/14, 08:35
-
Anja Leichsenring commented on patch set 3 06/30/14, 09:04
LiveSearch.php:182this removal should not be part of the patch. -
Markus Klein commented on patch set 3 06/30/14, 09:07
LiveSearch.php:182ReplyFeel free to split it into a separate patch. This just an unused line. Curiously I created that patch before the second ticket (about this line) got created, so I just changed the commit message to resolve also this second ticket. -
Nicole Hummel commented on patch set 3 06/30/14, 09:08
LiveSearch.php:182ReplyAny reason? -
Anja Leichsenring commented on patch set 3 CR +1 06/30/14, 09:18
LiveSearch.php:182Replyokay, someone moved it before. so fine with me. -
Helmut Hummel commented on patch set 3 CR +1 06/30/14, 10:40
This should be fine as Ajax requests have a complete backend bootstrap, so calling the API method here (which relies on a complete TCA) is fine. -
Nicole Hummel commented on patch set 3 V +2 06/30/14, 11:56
TCA is loaded with init.php (TYPO3\CMS\Core\Core\Bootstrap::loadExtensionTables(TRUE)) -
Christian Kuhn voted on patch set 3 V +2 CR +2 06/30/14, 15:11
-
Christian Kuhn merged patch set 4 06/30/14, 15:11
-
Christian Kuhn commented on patch set 4 06/30/14, 15:12
Cherry Picked This patchset was cherry picked to change: Ic4aaabed47922863602e770b588fb8dacd9386de