Review TYPO3_6-2 Merged

31289[TASK] Create a Getter for CacheManager inside Datahandler

Anja Leichsenring CR +2 V +2 Easy +16 −7 updated 07/02/14, 12:03

Commit message

At the moment the CacheManager is created by
GeneralUtility::makeInstance(
  'TYPO3\\CMS\\Core\\Cache\\CacheManager'
); within the code. This makes the particular method untestable.

Solution: Create a Getter which creates and returns the instance.
This getter can be mocked.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1