Review main Merged

31333[BUGFIX] Give extension key to addPlugin() in registerPlugin()

Christian Kuhn CR +2 V +2 Normal +78 −2 updated 07/05/14, 12:19

Commit message

With patch #59770 ExtensionManagementUtility::addPlugin() signature
was extended to get the extensionKey as parameter in order to not
use $GLOBALS['_EXTKEY'] anymore if possible.
The parameter is used to determine correct path to plugin icons if
the icon path is not given otherwise.
The patch changes extbase ExtensionUtility::registerPlugin() to give
the extensionKey to addPlugin, too.
With this patch registerPlugin() can be used in TCA/Overrides.
Some tests are added to verify the icon path calculation since it is
not trivial to follow the code flow with all its options and global
array access.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Anja Leichsenring +1
    • Marcin Sągol +1
  • Verified V +2
    • Wouter Wolters +2
    • Anja Leichsenring +1

Issues 4

Files 3

Review log 8

  1. Anja Leichsenring updated the commit message in patch set 1 07/05/14, 11:54

  2. Anja Leichsenring voted on patch set 2 V +1 CR +1 07/05/14, 11:55

  3. Mr. Jenkins commented on patch set 1 07/05/14, 12:04

  4. Marcin Sągol voted on patch set 2 CR +1 07/05/14, 12:04

  5. Wouter Wolters voted on patch set 2 V +2 CR +2 07/05/14, 12:09

  6. Wouter Wolters merged patch set 3 07/05/14, 12:09

  7. Wouter Wolters commented on patch set 3 07/05/14, 12:09

    Cherry Picked This patchset was cherry picked to change: I2dd709ef7ca304bc8c4fda1e7911f18bfe7ad04c
  8. Mr. Jenkins commented on patch set 2 07/05/14, 12:19