Review main Merged

31472[BUGFIX] Avoid PHP warning in TypoScriptFrontendController

Markus Klein CR +2 V +2 Easy +2 −2 updated 07/18/14, 22:54

Commit message

TypoScriptFrontendController throws a PHP warning on access to
$BE_USER->user['uid'] which might not be set.
Fix this by simply adding an empty() check.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Wouter Wolters +1
    • Marcin Sągol +1
  • Verified V +2
    • Stefan Neufeind +2

Issues 1

Files 1

Review log 7

  1. Wouter Wolters voted on patch set 1 CR +1 07/07/14, 21:19

  2. Mr. Jenkins commented on patch set 1 07/07/14, 21:20

  3. Marcin Sągol voted on patch set 1 CR +1 07/07/14, 21:20

  4. Marcin Sągol commented on patch set 1 07/07/14, 21:33

    I wonder what would be the best way to test it? Leave backend opened for a while like before or we can assume this fix is fine without serious testes as the fix is pretty obvious?
  5. Stefan Neufeind commented on patch set 1 CR +2 V +2 07/18/14, 22:54

    merging this as "pretty obvious"
  6. Stefan Neufeind merged patch set 1 07/18/14, 22:54

  7. Stefan Neufeind commented on patch set 2 07/18/14, 22:54

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 30958bc827ce1c9a9711dcffd62b1e32a1ef54c8