31571[BUGFIX] sys_collection_entries column too small
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Oliver Klee +1
- Markus Klein +1
- Ernesto Baschny +1
-
Verified V +2
- Stefan Neufeind +2
- Markus Klein +1
Issues 1
Files 1
Review log 16
-
Mr. Jenkins commented on patch set 1 07/10/14, 18:53
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/17322/ : SUCCESS -
Markus Klein commented on patch set 1 07/10/14, 18:54
on mysql... but not on otherswhom do we need to ask for 6.2 permission? -
Markus Klein voted on patch set 1 CR +1 07/10/14, 18:54
-
Wouter Wolters commented on patch set 1 07/11/14, 10:57
Reply
Should we change the commit message then?Reply
IMO this change isn't if you don't have any trouble. People who are having trouble can update their database. I see this as a non breaking change. -
Markus Klein commented on patch set 1 07/11/14, 11:05
Reply
Will doReply
Me too, but usually the team was very very strict about DB changes. I'd opt for changing this rule, such that we do allow changes like this. -
Markus Klein updated the commit message in patch set 1 07/11/14, 11:06
-
Markus Klein voted on patch set 2 CR +1 07/11/14, 11:06
-
Markus Klein voted on patch set 2 V +1 07/11/14, 11:06
-
Mr. Jenkins commented on patch set 2 07/11/14, 11:36
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/17341/ : SUCCESS -
Stefan Neufeind commented on patch set 2 CR +1 07/13/14, 20:12
I agree that the change might be "okay" since updating the DB is optional here (nothing breaks/fails if you don't). But I also thought about the stricktness in the past regarding DB-changes (for 6.2). Personally I'm fine with the change. -
Stefan Neufeind commented on patch set 2 07/18/14, 22:44
Let's wait for Ernesto regarding 6.2. I just emailed him. -
Oliver Klee voted on patch set 2 CR +1 07/20/14, 17:33
-
Ernesto Baschny commented on patch set 2 CR +1 07/20/14, 21:13
Good catch, go ahead -
Stefan Neufeind commented on patch set 2 CR +2 V +2 07/20/14, 21:20
Let's have it in. -
Stefan Neufeind merged patch set 2 07/20/14, 21:20
-
Stefan Neufeind commented on patch set 3 07/20/14, 21:20
Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 96ce4beee70a01908ece732cfae1f0e606cd1a42