31634[BUGFIX] Severity for max_execution_time < 240s too high
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 14
-
Philipp Gampe uploaded patch set 1 07/15/14, 22:37
-
Oliver Klee voted on patch set 1 CR +1 07/16/14, 10:46
-
Stefan Neufeind commented on patch set 1 CR +1 V +1 07/18/14, 16:16
For what reason did we choose 240s anyway? I've used 30s regularly and didn't experience problems so far. Imho usually if 30s is too short, usually the solution for the case is wrong, not the timeout. Nothing really to "verify" here. -
Markus Klein voted on patch set 1 CR +1 07/18/14, 16:29
-
Wouter Wolters commented on patch set 1 07/18/14, 17:06
If I remember correctly this is set to a high value because of the Extension Manager import. Maybe ask Christian about this one. -
Christian Kuhn commented on patch set 1 CR -1 07/24/14, 15:46
Yeah, extension manager is one reason ... this can easily take longer than 30s. Also some scheduler tasks or migrations could some time. I'd like to stay with both the warning status and with the status of 240 seconds. Also, system environment is an admin related thing, so it does not matter much if a "user" can not change it. All we can do from core point of view is hinting users for common pitfalls. If the timeout thing needs more explanation, we should improve the wording. -
Frank Nägler commented on patch set 1 V +1 09/17/14, 21:54
I agree with Christian, 30s is not enough, TYPO3 need at least 200s, this is the default for all my installations, sometimes I need to set this value higher. I think this patch should be abandoned. Also no activity since some month. -
Frank Nägler wrote 09/17/14, 21:54
Removed the following approvals: * Verified+1 by Frank Nägler <typo3@naegler.net> -
Frank Nägler commented on patch set 1 CR -1 09/17/14, 21:54
I agree with Christian, 30s is not enough, TYPO3 need at least 200s, this is the default for all my installations, sometimes I need to set this value higher. I think this patch should be abandoned. Also no activity since some month. -
Wouter Wolters voted on patch set 1 CR -1 09/17/14, 23:16
-
Stefan Neufeind commented on patch set 1 09/20/14, 23:20
Well, do we abandon this then? I can live with either decision. -
Benni Mack commented on patch set 1 10/20/14, 20:24
Full ack with Christian K. here (although the EM doesn't need 200sec anymore ;)). I opt for keeping it as it is. -
Philipp Gampe commented on patch set 1 11/12/14, 19:23
I am fine with abandon this as soon either 1. I can silence individual warnings in the scheduler system check 2. All reports do not trigger warnings on regular hostings My patch is about the later, but I think the former would be more useful in the long run. -
Christian Kuhn abandoned the change 11/12/14, 21:50
abandoned. the severity will not be changed.