Review main Merged

31718[BUGFIX] Fix return value of DatabaseConnection::sql_free_result()

Stefano Kowalke CR +2 V +2 Easy +2 −1 updated 07/22/14, 11:20

Commit message

In case of success the current implementation returns the result
of $res->free(). Unfortunately free() doesn't return anything.
That causes sql_free_result() to return NULL, which eventually
evaluates to FALSE.

Make sure the return value is correct and
return TRUE in case of success.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1

Issues 1

Files 1

Review log 6

  1. Stefano Kowalke uploaded patch set 1 07/22/14, 10:58

  2. Markus Klein updated the commit message in patch set 2 07/22/14, 11:12

  3. Markus Klein commented on patch set 2 CR +1 V +1 07/22/14, 11:12

    Good catch, thank you.
  4. Wouter Wolters voted on patch set 2 V +2 CR +2 07/22/14, 11:20

  5. Wouter Wolters merged patch set 2 07/22/14, 11:20

  6. Wouter Wolters commented on patch set 3 07/22/14, 11:20

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 2cb572ad26cd9cb3d88fe76de2dc66fc66c34e95