Review main Merged Breaking

31820[!!!][TASK] Deprecate all client related condition matchers

Sascha Egerer CR +2 V +2 Easy +42 −1 updated 09/08/14, 13:17

Commit message

Conditions that depend on client details are unlovely for a number
of reasons:

* Per condition or permutation of conditions that matches, the frontend
  creates a different cache entry. This can lead to a very high number
  of cache entrys per page
* Most usual conditions for specific browsers can nowadays turned into
  conditional CSS includes
* Conditions based on browser or clients on server side are
  bad practice.
* If conditions for specific clients or devices are still needed, they
  should be done with a userFunc condition and a project like WURFL
  that keep the device information more recent than the current core
  code like matching AMIGA
* Setups like reverse proxies give additional headaches with these
  types of conditions
* All client related condition types are deprecated with this patch.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2