Review main Merged

3183[TASK] Update information in INSTALL.txt to meet requirements

Markus Bucher CR +2 V +2 Easy +10 −7 updated 06/03/13, 20:49

Commit message

Review

  • Code review CR +2
    • Georg Ringer +2
    • Xavier Perseguers +2
    • Kilian Hann +1
    • Philipp Gampe +1
  • Verified V +2
    • Georg Ringer +2
    • Xavier Perseguers +2
    • Philipp Gampe +1

Issues 1

Files 1

Review log 18

  1. Philipp Gampe commented on patch set 1 07/11/11, 06:50

    (4 inline comments) see my comments

    INSTALL.txt:8

    of or by ... by sounds more natural, but I am german

    INSTALL.txt:63

    turn on whitespace error box on top of this diff view. Here and below is a tab at the end of line

    INSTALL.txt:66

    s/installed/activated You don't install the safe mode. You can turn it on or off.

    INSTALL.txt:106

    While you are at it ... TYPO3 4.3.0 ... use x.y.z here like it was done below.
  2. Mr. Jenkins commented on patch set 1 07/11/11, 06:50

  3. Mr. Jenkins commented on patch set 2 07/11/11, 06:50

  4. Markus Bucher uploaded patch set 2 07/11/11, 06:50

  5. Ernesto Baschny commented on patch set 3 2 comments 07/11/11, 06:50

    I would prefer that you didn't submit this Change is good, only the change of the standard header needs to be removed from this changeset and discussed separately.
  6. Philipp Gampe commented on patch set 3 07/11/11, 06:50

    Looks good to me, but someone else must approve
  7. Mr. Jenkins commented on patch set 3 07/11/11, 06:50

  8. Markus Bucher uploaded patch set 3 07/11/11, 06:50

  9. Mr. Jenkins commented on patch set 4 07/11/11, 06:50

  10. Markus Bucher uploaded patch set 4 07/11/11, 06:50

  11. Georg Ringer commented on patch set 5 V 0 07/11/11, 06:50

    by team member; Looks good to me, approved
  12. Philipp Gampe commented on patch set 5 07/11/11, 06:50

    Verified; Looks good to me, but someone else must approve Looks ok now n thanks for your work.#
  13. Mr. Jenkins commented on patch set 5 07/11/11, 06:50

  14. Kilian Hann commented on patch set 5 07/11/11, 06:50

    Looks good to me, but someone else must approve
  15. Markus Bucher commented on patch set 5 07/11/11, 06:50

    Should be okay now.
  16. Markus Bucher uploaded patch set 5 07/11/11, 06:50

  17. Xavier Perseguers commented on patch set 5 V 0 07/11/11, 06:50

    by team member; Looks good to me, approved Thanks for taking care
  18. Xavier Perseguers merged patch set 5 07/11/11, 06:50