Review main Merged

3186[CLEANUP] make TCEmain::getInlineFieldType() more understandable

Andreas Wolf CR +2 V +2 Easy +13 −15 updated 06/03/13, 20:49

Commit message

With 933254e2e69df05b41ae1f3b026a8f4c6f8fc09d, the method was made more
complicated without an obvious need for that. This patch reverts these
change, plus moving the guard clause to the beginning with an early
return in it, thus making the structure even more obvious.

This change has been integrated into the original patch for 4.5.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Files 1