Review main Merged

3210[TASK] Deprecate Content Object HTML

Kai Ole Hartwig CR +2 V +2 Easy +2 −2 updated 06/03/13, 20:49

Commit message

Since TYPO3 4.5 TEXT and HTML behave the same way.
HTML does not really make sense anymore and as such
could be deprecated.

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Stefan Neufeind +1
    • Jo Hasenau +1
    • Sebastian Michaelsen +1
    • Markus Klein +1
  • Verified V +2
    • Xavier Perseguers +2
    • Jo Hasenau +1
    • Markus Klein +1

Issues 1

Files 1

Review log 26

Show 1 earlier messages
  1. Xavier Perseguers commented on patch set 1 07/12/11, 09:01

    I would prefer that you didn't submit this Please have a look at my comments but above all, your patch does not simply deprecate the method but changes the whole method (basically by using other variable names). Please make sure you use TYPO3_master code to create your patch.

    class.tslib_content_html.php:34

    @deprecated since TYPO3 4.6, will be removed in TYPO3 4.8 - use TEXT from now on

    class.tslib_content_html.php:44

    Please add a call to t3lib_div::logDeprecatedFunction(); here at the beginning of this method
  1. Markus Klein commented on patch set 2 07/12/11, 09:01

    I would prefer that you didn't submit this CGL issues. Where is the updated documentation that HTML now works like TEXT? As I understand deprecation, things should stay the same, even when they are deprecated. If you really gonna change this behavior, add a BIG note to NEWS.TXT, 'cause this will for sure break loads of extensions using HTML!
  2. Chris topher commented on patch set 2 07/12/11, 09:01

    I would prefer that you didn't submit this The patch does not do what the issue asks for. The patch changes how the complete object works, changes variable names and such, while it indeed should only be about adding the 2 lines about deprecation.
  3. Kai Ole Hartwig uploaded patch set 2 07/12/11, 09:01

  4. Markus Klein commented on patch set 3 07/12/11, 09:01

    I would prefer that you didn't submit this Don't change the functionality! Or at least tell a damn good reason for this.
  5. Georg Ringer commented on patch set 3 07/12/11, 09:01

    Looks good to me, but someone else must approve

    class.tslib_content_html.php:45

    whitespace
  6. Sebastian Michaelsen commented on patch set 3 07/12/11, 09:01

    I would prefer that you didn't submit this I think it doesn't make sense to change the behaviour of HTML. Leave its behaviour as it is, deprecate it, remove it in 4.8 Changing it will bring no benefits, but will just break a lot of websites.
  7. Sebastian Michaelsen commented on patch set 3 07/12/11, 09:01

    No score
  8. Kai Ole Hartwig uploaded patch set 3 07/12/11, 09:01

  9. Markus Klein uploaded patch set 5 07/12/11, 09:01

  10. Stefan Neufeind commented on patch set 6 07/12/11, 09:01

    Looks good to me, but someone else must approve
  11. Markus Klein uploaded patch set 6 07/12/11, 09:01

  12. Markus Klein commented on patch set 6 07/12/11, 09:01

    Verified; Looks good to me, but someone else must approve Just cleaned the whitespace issues and removed the news entry again.
  13. Xavier Perseguers commented on patch set 6 V 0 07/12/11, 09:01

    by team member; Looks good to me, approved
  14. Xavier Perseguers commented on patch set 6 07/12/11, 09:01

    Looks good to me, but someone else must approve
  15. Sebastian Michaelsen commented on patch set 6 07/12/11, 09:01

    Looks good to me, but someone else must approve
  16. Kai Ole Hartwig uploaded patch set 4 07/12/11, 09:01

  17. Jo Hasenau commented on patch set 2 07/12/11, 09:01

    Verified; Looks good to me, but someone else must approve After the release of 4.5 the HTML object will behave just like the TEXT object until it will be removed after the deprecation period. This is why the code has been copied from TEXT to HTML, which doesn't break the behaviour but makes it clear even codewise, that there is a redundant object.
  18. Jo Hasenau commented on patch set 6 07/12/11, 09:01

    Verified; Looks good to me, but someone else must approve
  19. Mr. Jenkins commented on patch set 1 07/12/11, 09:01

  20. Mr. Jenkins commented on patch set 2 07/12/11, 09:01

  21. Mr. Jenkins commented on patch set 3 07/12/11, 09:01

  22. Mr. Jenkins commented on patch set 4 07/12/11, 09:01

  23. Mr. Jenkins commented on patch set 5 07/12/11, 09:01

  24. Mr. Jenkins commented on patch set 6 07/12/11, 09:01

  25. Xavier Perseguers merged patch set 6 07/12/11, 09:01