Review TYPO3_4-5 Merged

3240[BUGFIX] t3lib_div::debugRows doesn't return data

Xavier Perseguers CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

In TYPO3 4.5 t3lib_div::debugRows() was deprecated
and moved to t3lib_utility_Debug::debugRows().
The problem is, that t3lib_utility_Debug::debugRows()
is just called but not returned, despite the fact
that debugRows() offers an option $returnHTML to
return an HTML table.
So in the (a bit unlikely) case someone relies on
values returned by t3lib_div::debugRows(), 4.5 broke
his code.

Adding a simple "return" will solve this problem.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1