Review TYPO3_4-5 Merged

3268[BUGFIX] t3lib_div::cmpIPv6() fails to compare

Xavier Perseguers CR +2 V +2 Normal +152 −27 updated 06/03/13, 20:49

Commit message

cmpIPv6 makes wrong assumptions about the output of IPv6Hex2Bin().
Also currently only netmasks of /48, /64 and /128 are supported.

Added a cleanup for an E_NOTICE on exploding the bitmask.
Replaced IPv6Hex2Bin() with php function (same output, just quicker).
Added testcases.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2