Review main Merged

32760[BUGFIX] Reset ExtJS 3 CSS box-model

Felix Kopp CR +2 V +2 Easy +6 −0 updated 09/14/14, 14:35

Commit message

We have box-models in CSS. They define how the dimensions of
elements are calculated. Modern CSS is based on the border-box
outline definition where the *outer* dimensions are defined and
not the *inner* dimensions.

Bootstrap, Foundation and ExtJS 4 use the modern box sizing
"border-box". This is the default now.

ExtJS 3 CSS is based on the "old" content-box definition. Since
CMS still uses ExtJS 3 we need to move ExtJS elements back into
the former box-sizing mode.

This patch sets box-sizing back to the previous content-box for
input fields. Most dimensions in other widgets and elements are
calculated with the help of JS and not based on CSS itself. Thus
.x-form-field should be enought for the start.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 1