Review main Merged

3324[BUGFIX] stdWrap.hash: Return nothing for non-existing algorithm

Stefan Neufeind CR +2 V +2 Easy +4 −1 updated 06/03/13, 20:49

Commit message

Return an empty string to prevent disclosing information unhashed.

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Jo Hasenau +1
  • Verified V +2
    • Xavier Perseguers +2
    • Jo Hasenau +1

Issues 1

Files 2

Review log 9

  1. Stefan Neufeind uploaded patch set 2 07/14/11, 19:18

  2. Stefan Neufeind commented on patch set 2 07/14/11, 19:18

    about the dep: sorry, didn't properly reset the local installation adjusted comment to explicitly say aim is not to disclose information
  3. Xavier Perseguers commented on patch set 1 07/14/11, 19:18

    Verified; I would prefer that you didn't submit this You'll have my +1 on code after removing the dependency in your patch
  4. Xavier Perseguers commented on patch set 2 07/14/11, 19:18

    Verified; Looks good to me, but someone else must approve
  5. Jo Hasenau commented on patch set 2 07/14/11, 19:18

    Verified; Looks good to me, but someone else must approve
  6. Mr. Jenkins commented on patch set 1 07/14/11, 19:18

  7. Mr. Jenkins commented on patch set 2 07/14/11, 19:18

  8. Xavier Perseguers commented on patch set 2 V 0 07/14/11, 19:18

    by team member; Looks good to me, approved
  9. Xavier Perseguers merged patch set 2 07/14/11, 19:18