Review TYPO3_4-7 Abandoned

33255[BUGFIX] Do not call methods the static way

Stefan Froemken CR 0 V 0 Easy +20 −18 updated 10/13/14, 21:20

Commit message

Many calls to tslib_cObj methods are realized
by static calls (::). As long as the requirements
for TYPO3 4.7 includes PHP 5.5 we have to change
these calls to the object style (->).

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 4

  1. Stefan Froemken uploaded patch set 1 10/10/14, 22:53

  2. Stefan Froemken uploaded patch set 2 10/10/14, 22:55

  3. Christian Kuhn commented on patch set 2 CR -1 10/13/14, 21:11

    Mmmmh, multiple problems with this one: * I think we fixed that is younger versions already, and I also roughly remember some regression after we did it. * This patch is not trivial to verify, and includes 3rd party callers: It is very well possible that some of the calling methods are currently called statically by itself. If those now call $this, you'll get a fatal. * 4.7 is e-o-l since 10/2014, so it shouldn't even get security related patches anymore. All in all, imho risk / benefit of this patch is not good enough to consider further reviews. I'd opt to abandon and close with "won't fix".
  4. Stefan Froemken abandoned the change 10/13/14, 21:20

    TYPO3 4.7 maintainance ends this october