Review main Merged

33469[FEATURE] Base Buttons on Bootstrap - with compat layer

Felix Kopp CR +2 V +2 Hard +379 −252 updated 10/23/14, 19:32

Commit message

Bring default button style and base CSS definitions on Bootstrap
buttons. Brings backward compatibility for all buttons.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Ingo Pfennigstorf +1
  • Verified V +2
    • Wouter Wolters +2
    • Ingo Pfennigstorf +1

Files 3

Review log 11

  1. Felix Kopp uploaded patch set 1 10/22/14, 09:59

  2. Georg Ringer voted on patch set 1 V +1 CR +1 10/22/14, 14:08

  3. Wouter Wolters voted on patch set 1 V +1 CR +1 10/22/14, 17:00

  4. Ingo Pfennigstorf commented on patch set 1 10/22/14, 20:44

    Bootstrap base is ok. The buttons do not yet really fit into the scheme due to the massive rounded borders. Suggestion: decrease the border radius to 2px or (even better) to 0.
  5. Felix Kopp commented on patch set 1 10/22/14, 23:00

    I think the radius for buttons / primary actions is okay in order to differentiate tab style / input style / module style. If we reduce the radius another style has to emerge: gradient or strong outline or something else. Don't you think? Also this is a hybrid patch: styling + clean-up / base on bootstrap. I think that patch is ready to go - but let us discuss styles on slack/forge.
  6. Felix Kopp uploaded patch set 2 10/23/14, 09:01

  7. Felix Kopp commented on patch set 1 10/23/14, 09:01

    Changed to 2px :)
  8. Wouter Wolters voted on patch set 2 V +1 CR +1 10/23/14, 09:02

  9. Ingo Pfennigstorf voted on patch set 2 CR +1 V +1 10/23/14, 19:22

  10. Wouter Wolters voted on patch set 2 V +2 CR +2 10/23/14, 19:32

  11. Wouter Wolters merged patch set 2 10/23/14, 19:32