Review main Merged

33712[CLEANUP] Cleanup EXT:rsaauth

Mathias Schreiber CR +2 V +2 Normal +23 −29 updated 11/03/14, 15:46

Commit message

EXT:rsaauth has several minor flaws codewise that make
PHPStorms inspection go wild:
* Clean up direct usage of $GLOBALS[TYPO3_DB].
* TCA of tx_rsaauth_keys is not needed and can be removed, as a
result, "Oops! You should not see this" no longer shows
up in db_lowlevel.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2