Review main Merged

34358[BUGFIX] mysqli_stmt::reset may throw a PHP warning

Xavier Perseguers CR +2 V +2 Easy +1 −1 updated 11/19/14, 17:20

Commit message

Review

  • Code review CR +2
    • Markus Klein +2
    • Xavier Perseguers +2
    • Mathias Schreiber +1
  • Verified V +2
    • Markus Klein +2
    • Xavier Perseguers +2

Issues 1

Files 1

Review log 8

  1. Xavier Perseguers uploaded patch set 1 11/19/14, 16:28

  2. Mathias Schreiber commented on patch set 1 11/19/14, 16:31

    proper error handling impossible here?
  3. Xavier Perseguers commented on patch set 1 11/19/14, 16:37

    I don't think so, that's like many other native PHP calls to files, they may throw PHP warnings without even having them documented: http://php.net/manual/en/mysqli-stmt.reset.php
  4. Mathias Schreiber commented on patch set 1 CR +1 11/19/14, 16:38

    No clue how to raise an error here so how do I +1 verify this? Can we make an exception here and just vote the @ through?
  5. Xavier Perseguers commented on patch set 1 CR +2 V +2 11/19/14, 17:02

    This is similar to many other issues, giving my +2 everywhere but not merging if anyone absolutely wants to actively test
  6. Markus Klein commented on patch set 1 CR +2 V +2 11/19/14, 17:19

    get it in
  7. Markus Klein merged patch set 1 11/19/14, 17:19

  8. Markus Klein commented on patch set 2 11/19/14, 17:20

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 1cda50c061f887fe1c4cbda26d6d748452c854fa