Review TYPO3_4-5 Merged

3436[BUGFIX] Cache FileBackend does not respect fileCreateMask

Steffen Gebert CR +2 V +2 Easy +1 −0 updated 06/03/13, 20:49

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Helmut Hummel +1
    • Philipp Gampe +1
  • Verified V +2
    • Christian Kuhn +2
    • Helmut Hummel +1

Issues 1

Files 1

Review log 9

  1. Stefan Neufeind commented on patch set 1 08/01/11, 12:11

    Looks good to me, but someone else must approve looks okay, no-brainer, already commited for master at https://review.typo3.org/3422
  2. Stefan Neufeind commented on patch set 1 08/01/11, 12:11

    Christian, could you please have a quick look? With a hint we could continue getting this one in shape. (Not a bit patch after all.)
  3. Helmut Hummel commented on patch set 1 08/01/11, 12:11

    Verified; Looks good to me, but someone else must approve obvious I would say
  4. Christian Kuhn commented on patch set 1 V 0 08/01/11, 12:11

    by team member; Looks good to me, approved Identical to master version. Merged.
  5. Georg Ringer commented on patch set 1 08/01/11, 12:11

    why not use t3lib_div::writeFile() instead of file_put_contents, this also takes care about the rights?
  6. Steffen Gebert commented on patch set 1 08/01/11, 12:11

    Yes, I also thought about this. I was just unsure, because of automatically backporting the code from FLOW3. Invited Christian to have a look.
  7. Philipp Gampe commented on patch set 1 08/01/11, 12:11

    Looks good to me, but someone else must approve
  8. Mr. Jenkins commented on patch set 1 08/01/11, 12:11

  9. Christian Kuhn merged patch set 1 08/01/11, 12:11