3436[BUGFIX] Cache FileBackend does not respect fileCreateMask
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Stefan Neufeind +1
- Helmut Hummel +1
- Philipp Gampe +1
-
Verified V +2
- Christian Kuhn +2
- Helmut Hummel +1
Issues 1
Files 1
Review log 9
-
Stefan Neufeind commented on patch set 1 08/01/11, 12:11
Looks good to me, but someone else must approve looks okay, no-brainer, already commited for master at https://review.typo3.org/3422 -
Stefan Neufeind commented on patch set 1 08/01/11, 12:11
Christian, could you please have a quick look? With a hint we could continue getting this one in shape. (Not a bit patch after all.) -
Helmut Hummel commented on patch set 1 08/01/11, 12:11
Verified; Looks good to me, but someone else must approve obvious I would say -
Christian Kuhn commented on patch set 1 V 0 08/01/11, 12:11
by team member; Looks good to me, approved Identical to master version. Merged. -
Georg Ringer commented on patch set 1 08/01/11, 12:11
why not use t3lib_div::writeFile() instead of file_put_contents, this also takes care about the rights? -
Steffen Gebert commented on patch set 1 08/01/11, 12:11
Yes, I also thought about this. I was just unsure, because of automatically backporting the code from FLOW3. Invited Christian to have a look. -
Philipp Gampe commented on patch set 1 08/01/11, 12:11
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 08/01/11, 12:11
Build Successful http://ci.typo3.org/job/typo3-v4-core_4-5-gerrit/216/ : SUCCESS -
Christian Kuhn merged patch set 1 08/01/11, 12:11