Review main Abandoned

3438[BUGFIX] imageLinkWrap and StdWrap Inconsistent

Sebastian Steinmetz CR 0 V 0 Easy +7 −5 updated 06/03/13, 20:49

Commit message

Apply stdWrap only on the parts inside the link created by imageLinkWrap

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 13

  1. Oliver Hader uploaded patch set 3 02/01/12, 00:07

  2. Oliver Hader commented on patch set 3 02/01/12, 00:07

    I would prefer that you didn't submit this Rebasing to master V:0, R:-1 V:0, R:-1 from Steffen Gebert <steffen.gebert@typo3.org> V:0, R:-1 from Jo Hasenau <info@cybercraft.de>
  3. Steffen Gebert commented on patch set 2 02/01/12, 00:07

    I would prefer that you didn't submit this Hi Sebastian, thanks for your contribution. I've uploaded a new Patch Set, which brings the code and commit message a bit in form. Could you please describe in #28350, why this change makes sense in your opinion? Thanks Steffen
  4. Steffen Gebert uploaded patch set 2 02/01/12, 00:07

  5. Chris topher commented on patch set 1 02/01/12, 00:07

    I would prefer that you didn't submit this I guess this belongs to #28350. I don't see what your patch changes. But it duplicates the code making it more complicated than it has to be.
  6. Sebastian Steinmetz commented on patch set 2 02/01/12, 00:07

    I explained a bit more in #28350. I know code duplication isn't a good way fixing this, but it was the easiest, and it's just 3 lines of code. If you are willing to integrate a patch fixing this reported bug, I could have another look at it, and solve it without duplicating the if-statement. Thanks, Seb
  7. Jo Hasenau commented on patch set 2 02/01/12, 00:07

    I would prefer that you didn't submit this
  8. Jo Hasenau commented on patch set 2 02/01/12, 00:07

    I still don't get what exactly should be the actual bug in this case and why we should fix it.
  9. Jo Hasenau commented on patch set 2 02/01/12, 00:07

    Discussed the problem via Skype. - Actually the bug is, that stdWrap is not applied to the result of imageLinkWrap as the last function, but still before "wrapping" the JSwindow stuff by concatenating 3 strings at the end of the function. If we changed that, it would be a breaking change AND it would still not solve the problem, since it would be even worse, because you could not apply anything inside the link tags anymore, which is working at least for JSwindow at the moment. So we have to find another solution, but I guess this would be more like a Feature request then, since it would require another stdWrap function within the link tags.
  10. Mr. Jenkins commented on patch set 1 02/01/12, 00:07

  11. Mr. Jenkins commented on patch set 2 02/01/12, 00:07

  12. Mr. Jenkins commented on patch set 3 02/01/12, 00:07

  13. Steffen Gebert commented on patch set 3 02/01/12, 00:07

    Abandoned Abandoned due to lack of feedback or activity.