Review main Merged

34399[CLEANUP] ClickMenu internal code cleanup

Benni Mack CR +2 V +2 Hard +158 −261 updated 11/23/14, 13:09

Commit message

As a followup to the API changes
of the clickmenu within #62709 this
change removes any leftovers
of the internals of the clickmenu
using e.g. non-sprite icons, and
removing all non-AJAX-functionality
which was used via alt_clickmenu.php
without &ajax=1 (for the very old topbar
in pre-4.2).

Additionally, it deprecates alt_clickmenu.php,
which was already announced in #62709. The
prehistoric user UC option "noMenuMode"
was also removed completely.

A final followup will bring a non-table output
as well as cleaned up JS calls, and a JSON
based data exchange.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 7