Review main Merged Breaking

34409[!!!][TASK] Clean up OpendocsToolbarItem references

Christian Kuhn CR +2 V +2 Hard +35 −258 updated 11/20/14, 21:06

Commit message

With toolbar refactoring, OpendocsController was renamed
to OpendocsToolbarItem and a class alias was introduced to
cope with core internal usages of the old class names. This
is cleaned up with this patch.

The class was still referenced in alt_doc_nodoc.php entry
point through EditDocumentController. This ancient code is
obsolete since around 4.3 but was never removed. The patch
now removes this entry point and redirects to dummy.php in
EditDocumentController just in case this code snippet is
still triggered somehow - which is unlikely, but can not be
overseen currently.

Furthermore, the alias OpendocsController is removed: The
new class implements a different interface now, so this
would break anyway - which is also unlikely to be used by
third party code.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 11